Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI #33

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Improve CI #33

merged 4 commits into from
Dec 18, 2023

Conversation

Earlopain
Copy link
Contributor

  • Actually run tests against rubocop master. The matrix contained the gemfile overwrite but it wasn't actually used anywhere. I've also changed it to use the Gemfile.local logic since that was already there.
  • Moved jruby to the testing matrix. There wasn't much difference between the files, except that jruby didn't run on scheduele previously but I don't think that was intentional.
  • Remove explicit CI: true. GitHub sets that automatically
  • Test against the earliest supported RuboCop version. I had to tweak one test that was passing an option unknown to earlier RuboCop versions. That option was renamed, and passing the shorthand avoids deprecation warnings on current versions.

palkan
palkan approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@palkan palkan merged commit 7644966 into rubocop:master Dec 18, 2023
12 checks passed
@Earlopain Earlopain deleted the expand-ci branch December 18, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palkan palkan palkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Earlopain @palkan