[Fix #210] Fix a false positive for `Minitest/EmptyLineBeforeAssertio…

…nMethodsTest`

Fixes #210.

This PR fixes a false positive for `Minitest/EmptyLineBeforeAssertionMethodsTest`
when using assertion method with block arg before other assertion method.

changelog/fix_a_false_positive_for_minitest_empty_line_before_assertion_methods.md

@@ -0,0 +1 @@
+* [#210](https://github.com/rubocop/rubocop-minitest/issues/210): Fix a false positive for `Minitest/EmptyLineBeforeAssertionMethodsTest` when using assertion method with block arg before other assertion method. ([@koic][])

lib/rubocop/cop/minitest/empty_line_before_assertion_methods.rb

@@ -53,7 +53,7 @@ def accept_previous_line?(previous_line_node, node)
           return true if !previous_line_node.is_a?(RuboCop::AST::Node) ||
                          previous_line_node.args_type? || node.parent.basic_conditional?
 
-          previous_line_node.send_type? && assertion_method?(previous_line_node)
+          assertion_method?(previous_line_node)
         end
 
         def use_heredoc_argument?(node)

lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -78,7 +78,7 @@ def assertions(def_node)
       end
 
       def assertion_method?(node)
-        return false unless node.send_type?
+        return false if !node.send_type? && !node.block_type?
 
         ASSERTION_PREFIXES.any? do |prefix|
           method_name = node.method_name

test/rubocop/cop/minitest/empty_line_before_assertion_methods_test.rb

@@ -395,4 +395,15 @@ class FooTest < Minitest::Test
       end
     RUBY
   end
+
+  def test_does_not_register_offense_when_using_assert_raises_with_block_arg_before_assertion_method
+    assert_no_offenses(<<~RUBY)
+      def test_do_something
+        assert_raises(CustomError) do
+          do_something
+        end
+        assert(thing)
+      end
+    RUBY
+  end
 end