Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minitest/AssertTruthy should be marked as unsafe for autocorrection #209

Closed
andyw8 opened this issue Dec 27, 2022 · 2 comments · Fixed by #211
Closed

Minitest/AssertTruthy should be marked as unsafe for autocorrection #209

andyw8 opened this issue Dec 27, 2022 · 2 comments · Fixed by #211
Labels
bug Something isn't working

Comments

@andyw8
Copy link
Contributor

andyw8 commented Dec 27, 2022

If the intention is to check for a true/false value rather than truthy or falsey, then the autocorrection could result in a test passing when it shouldn't.

Expected behavior

assert_equal true, item.flagged should not be autocorrected.

Actual behavior

It is auto-corrected to assert item.flagged. So the test would still pass even if flagged returned a string.

RuboCop version

rubocop-minitest (0.25.1)
@koic koic added the bug Something isn't working label Dec 30, 2022
koic added a commit to koic/rubocop-minitest that referenced this issue Dec 30, 2022
@koic
[Fix rubocop#209] Mark Minitest/AssertTruthy as unsafe autocorrection
3f56e4a 
Fixes rubocop#209.

This PR marks `Minitest/AssertTruthy` as unsafe autocorrection.
@koic koic mentioned this issue Dec 30, 2022
Merged
8 tasks
@koic koic closed this as completed in #211 Dec 30, 2022
koic added a commit that referenced this issue Dec 30, 2022
@koic
Merge pull request #211 from koic/mark_minitest_assert_truthy_as_unsa…
bd380af 
…fe_autocorrection

[Fix #209] Mark `Minitest/AssertTruthy` as unsafe autocorrection
@jana4u
Copy link

jana4u commented Jan 17, 2023

I think Minitest/RefuteFalse should be handled the same (marked as unsafe) to distinguish between nil and false then?

koic added a commit to koic/rubocop-minitest that referenced this issue Jan 21, 2023
@koic
Mark Minitest/RefuteFalse as unsafe autocorrection
ba9fa7c 
This PR marks `Minitest/RefuteFalse` as unsafe autocorrection.
rubocop#209 (comment)
koic added a commit to koic/rubocop-minitest that referenced this issue Jan 21, 2023
@koic
Mark Minitest/RefuteFalse as unsafe autocorrection
46f03a4 
Follow up rubocop#209 (comment)

This PR marks `Minitest/RefuteFalse` as unsafe autocorrection.
@koic koic mentioned this issue Jan 21, 2023
Merged
8 tasks
koic added a commit to koic/rubocop-minitest that referenced this issue Jan 21, 2023
@koic
Mark Minitest/RefuteFalse as unsafe
442c0ec 
Follow up rubocop#209 (comment)

This PR marks `Minitest/RefuteFalse` as unsafe.
@koic
Copy link
Member

koic commented Jan 21, 2023

@jana4u Good catch! I've opened #233.

koic added a commit to koic/rubocop-minitest that referenced this issue Jan 21, 2023
@koic
Mark Minitest/RefuteFalse as unsafe
5ca83aa 
Follow up rubocop#209 (comment)

This PR marks `Minitest/RefuteFalse` as unsafe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #209] Mark Minitest/AssertTruthy as unsafe autocorrection koic/rubocop-minitest
3 participants
@jana4u @koic @andyw8