New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-correct works other directories like acceptance
#73
Comments
koic
added a commit
to koic/rubocop-minitest
that referenced
this issue
Apr 10, 2020
Fixes rubocop#73. This PR changes the Minitest department works on file names end with `_test.rb` by default. RuboCop Minitest only targets files in `test` directory by default until v0.8.1. ```yaml Minitest: Enabled: true Include: - '**/test/**/*' ``` https://github.com/rubocop-hq/rubocop-minitest/blob/v0.8.1/config/default.yml But test files may be located in a directory other than `test` directory. This PR adds files that end of filename is `_test.rb` to be considered test files. This behavior is similar to how RuboCop RSpec works on `_spec.rb`. https://github.com/rubocop-hq/rubocop-rspec/blob/v1.38.1/config/default.yml#L5
8 tasks
RuboCop Minitest only targets files in Minitest:
Enabled: true
Include:
- '**/test/**/*' https://github.com/rubocop-hq/rubocop-minitest/blob/v0.8.1/config/default.yml#L1-L4 I opened #74. Probably I will make a new release soon. Thank you! |
koic
added a commit
that referenced
this issue
Apr 12, 2020
[Fix #73] The Minitest department works on `_test.rb` by default
FYI, RuboCop Minitest 0.9.0 has been released. |
Thanks for releasing RuboCop Minitest 0.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
While working on googleapis/google-cloud-ruby#5207 I also want
rubocop-minitest
performs auto-correct files underacceptance
directory of google-cloud-storageDescribe the solution you'd like
I'd like to know how to auto-correct these files under
acceptance
directory.Describe alternatives you've considered
Edit files manually, which requires 609 lines corrected.
Additional context
Let me provide steps to reproduce:
Steps to reproduce:
Expected result
Files under
acceptance
directory are auto-corrected byMinitest/GlobalExpectations
cop.Actual result:
Files under
acceptance
directory are not auto-corrected byMinitest/GlobalExpectations
cop.The text was updated successfully, but these errors were encountered: