Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #143] Fix an error for Minitest/LiteralAsActualArgumentTest #144

Merged

Conversation

koic
Copy link
Member

@koic koic commented Sep 23, 2021

Fixes #143.

This PR fixes an error for Minitest/LiteralAsActualArgumentTest when expected and actual arguments are literals.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_error_for_minitest_literal_as_actual_argument branch from 9771559 to d511db5 Compare September 23, 2021 16:53
…est`

Fixes rubocop#143.

This PR fixes an error for `Minitest/LiteralAsActualArgumentTest`
when expected and actual arguments are literals.
@koic koic force-pushed the fix_error_for_minitest_literal_as_actual_argument branch from d511db5 to 630a7f3 Compare September 23, 2021 17:02
@koic koic merged commit a666891 into rubocop:master Sep 24, 2021
@koic koic deleted the fix_error_for_minitest_literal_as_actual_argument branch September 24, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minitest/LiteralAsActualArgument infinitely loops when both args are literals.
2 participants