Fix a false positive for Minitest/MultipleAssertions when using assertion method with block
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 16, 2023
| @@ -15,6 +15,14 @@ def test_asserts_twice | |||
| assert_equal(foo, bar) | |||
| assert_empty(array) | |||
| end | |||
|
|
|||
| def test_asserts_three_times | |||
There was a problem hiding this comment.
Can you separate this new test example from existing def test_registers_offense_when_multiple_expectations (L10) to a new test method?
…ertion method with block
fatkodima
force-pushed
the
fix-multiple_assertions
branch
from
edefa3c
to
b0c7bae
Compare
|
Thanks! |
koic
added a commit
that referenced
this pull request
Jan 18, 2023
`[2/1]` and `[3/1]` may be detected incorrectly in multiple_assertions_test.rb of #224: https://app.circleci.com/pipelines/github/rubocop/rubocop-minitest/853/workflows/3da99133-155c-4bca-8e92-4c3287b537b6/jobs/5481 Another essential fix is needed, but this commit prevents a flaky test by unifying to `[2/1]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223.
assertions_countmethod was updated to count assertion-likesendnodes belonging toblocknode only once.