Add new Minitest/LifecycleHooksOrder cop
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
commented
Jan 19, 2023
rubocop-minitest.gemspec
Outdated
| @@ -32,6 +32,6 @@ Gem::Specification.new do |spec| | |||
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
| spec.require_paths = ['lib'] | |||
|
|
|||
| spec.add_runtime_dependency 'rubocop', '>= 0.90', '< 2.0' | |||
| spec.add_runtime_dependency 'rubocop', '>= 1.43', '< 2.0' | |||
There was a problem hiding this comment.
Upgraded rubocop because I need range_with_comments_and_lines from RangeHelp module.
Probably better done as a separate PR?
There was a problem hiding this comment.
It's a big jump, but let's still include it in this PR. By the way, it looks like this was introduced in 1.39, not 1.43.
rubocop/rubocop@0d6b0d1
Suggested change
| spec.add_runtime_dependency 'rubocop', '>= 1.43', '< 2.0' | |
| spec.add_runtime_dependency 'rubocop', '>= 1.39', '< 2.0' |
koic
reviewed
Jan 24, 2023
| MSG = '`%<current>s` is supposed to appear before `%<previous>s`.' | ||
|
|
||
| HOOKS_ORDER_MAP = Hash.new do |hash, hook| | ||
| hash[hook] = LIFECYCLE_HOOK_METHODS_IN_ORDER.index(hook) || 100 |
There was a problem hiding this comment.
Can you make the magic number 100 a constant and add an explanation of what it is?
fatkodima
force-pushed
the
lifecycle_hooks_order-cop
branch
from
b2f3788
to
49bdd91
Compare
|
Updated. |
koic
reviewed
Jan 25, 2023
|
|
||
| MSG = '`%<current>s` is supposed to appear before `%<previous>s`.' | ||
|
|
||
| REGULAR_METHOD_POSITION = 100 |
There was a problem hiding this comment.
It would be better if source commented why the value of 100 was chosen and set :-)
fatkodima
force-pushed
the
lifecycle_hooks_order-cop
branch
from
49bdd91
to
a028c03
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214.
Tested on
rails/rails- 5 valid offenses.