Fix some false negatives for Minitest/GlobalExpectations

[andrykonchin]

Fixed some use cases for the Minitest/GlobalExpectations cop.

I have noticed there are cases when the cop doesn't produce offenses:

• expectation for constant e.g. class/module
• method call with arguments
• expectation for chained hash references

Let's look at some examples which the cope ignores:

response[1]['X-Runtime'].must_match /[\d\.]+/

::File.read(::File.join(@def_disk_cache, 'path', 'to', 'blah.html')).must_equal @def_value.first

Rack::Contrib.must_respond_to(:release)

Related links

• Support DEPRECATED: global use of must_equal from ... Use _(obj).must_equal instead. This will fail in Minitest 6. #60
• [Fix #60] Add new cop Minitest/GlobalExpectations #63
• Fix a false negative for Minitest/GlobalExpectations cop #69

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

[koic]

To run a test, the prefix must start with test_.

Suggested change

	define_method(:"registers_offense_when_using_global_#{matcher}_for_chained_hash_reference") do
	define_method(:"test_registers_offense_when_using_global_#{matcher}_for_chained_hash_reference") do

And, if an appropriate method name exceeds the maximum length of Layout/LineLength, this repository allows the maximum length of Layout/LineLength of .rubocop_todo.yml to be increased. In that case, I think it will be 120 or less.

[andrykonchin]

@koic Good catch. It was just a typo when I polish the final formatting of the new specs. Fixed 👍.

Also I increased Layout/LineLength in the .rubocop.yml file and keep .rubocop_todo.yml unchanged as far as it's an autogenerated file. Please let me know it there is a more convenient way to increase a line max length and to solve the issue.

[koic]

Suggested change

	define_method(:"registers_offense_when_using_global_#{matcher}_for_method_call_with_params") do
	define_method(:"test_registers_offense_when_using_global_#{matcher}_for_method_call_with_params") do

[koic]

Suggested change

	define_method(:"registers_offense_when_using_global_#{matcher}_for_constant") do
	define_method(:"test_registers_offense_when_using_global_#{matcher}_for_constant") do

[koic]

Can you update .rubocop_todo.yml, not .rubocop.yml in this PR?

--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -20,4 +20,4 @@ Metrics/MethodLength:
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Layout/LineLength:
-  Max: 100
+  Max: 120

And other changes looks good to me. Can you squash your commits into one?

[andrykonchin]

@koic Done.

I fixed my mistake I've introduced in the pattern. The new pattern didn't support _'s aliases - value and expect. Added proper tests.

[koic]

Thanks!