Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Performance/Sum aware of safe navigation operator #401

Closed
ydakuka opened this issue Nov 30, 2023 · 0 comments · Fixed by #402
Closed

Make Performance/Sum aware of safe navigation operator #401

ydakuka opened this issue Nov 30, 2023 · 0 comments · Fixed by #402

Comments

@ydakuka
Copy link
Contributor

ydakuka commented Nov 30, 2023 •
edited

Describe the solution you'd like

# bad
def my_method
  result&.map(&:foo)&.sum
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.2 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
koic added a commit to koic/rubocop-performance that referenced this issue Dec 1, 2023
@koic
[Fix rubocop#401] Make Performance/Sum aware of safe navigation ope…
8a1f837 
…rator

Fixes rubocop#401.

This PR make `Performance/Sum` aware of safe navigation operator.
koic added a commit to koic/rubocop-performance that referenced this issue Dec 1, 2023
@koic
[Fix rubocop#401] Make Performance/Sum aware of safe navigation ope…
f130376 
…rator

Fixes rubocop#401.

This PR makes `Performance/Sum` aware of safe navigation operator.
@koic koic mentioned this issue Dec 1, 2023
Merged
8 tasks
@koic koic closed this as completed in #402 Dec 3, 2023
koic added a commit that referenced this issue Dec 3, 2023
@koic
Merge pull request #402 from koic/make_performance_sum_aware_of_safe_…
461168f 
…navigation_operator

[Fix #401] Make `Performance/Sum` aware of safe navigation operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #401] Make Performance/Sum aware of safe navigation operator koic/rubocop-performance
1 participant
@ydakuka