Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto-correct for Performance/StartWith and Performance/EndWith cops #212

Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 16, 2021

This PR enables auto-correct for Performance/StartWith and Performance/EndWith cops.
These cops are expected to be performed as unsafe auto-correction by default.

Thanks for the feedback @amatsuda!


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…ith` cops

This PR enables auto-correct for `Performance/StartWith` and `Performance/EndWith` cops.
These cops are expected to be performed as unsafe auto-correction by default.
@koic koic merged commit 199f360 into rubocop:master Feb 17, 2021
@koic koic deleted the enable_autocorrect_for_sart_with_and_end_with branch February 17, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant