Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AllowRegexpMatch of Performance/RedundantEqualityComparisonBlock by default #352

Conversation

koic
Copy link
Member

@koic koic commented Apr 9, 2023

This PR fixes AllowRegexpMatch of Performance/RedundantEqualityComparisonBlock by default.

Default value is true as documented example below:
https://docs.rubocop.org/rubocop-performance/cops_performance.html#performanceredundantequalitycomparisonblock


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ck` by default

This PR fixes `AllowRegexpMatch` of `Performance/RedundantEqualityComparisonBlock` by default.

Default value is true as documented example below:
https://docs.rubocop.org/rubocop-performance/cops_performance.html#performanceredundantequalitycomparisonblock
@koic koic force-pushed the fix_default_config_of_redundant_equality_comparison_block branch from 105060c to 91b35ba Compare April 9, 2023 07:03
@koic koic merged commit d9d53b1 into rubocop:master Apr 9, 2023
12 checks passed
@koic koic deleted the fix_default_config_of_redundant_equality_comparison_block branch April 9, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant