Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set target version for Performance/UnfreezeString #373

Conversation

tagliala
Copy link
Contributor

As stated in the class documentation, unary plus operator is available from Ruby 2.3.

This fix prevent RuboCop Performance to raise an offense when configured to support Ruby 2.2


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

As stated in the class documentation, unary plus operator is available
from Ruby 2.3.

This fix prevent RuboCop Performance to raise an offense when configured
to support Ruby 2.2
@tagliala tagliala marked this pull request as ready for review September 16, 2023 14:51
@koic koic merged commit 1b8df40 into rubocop:master Sep 16, 2023
10 checks passed
@koic
Copy link
Member

koic commented Sep 16, 2023

Good catch. Thanks!

@tagliala tagliala deleted the bugfix/fix-target-ruby-version-of-unfreeze-string branch September 16, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants