Make Performance/StringIdentifierArgument aware of string interpolation
#387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment`
Makes the cop aware of string interpolation.
```rb
require 'benchmark/ips'
puts `ruby -v`
def foo_bar
end
bar = "bar"
Benchmark.ips do |x|
x.report('symbol arg') { send(:"foo_#{bar}") }
x.report('string arg') { send("foo_#{bar}") }
x.compare!
end
```
```
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux-musl]
Warming up --------------------------------------
symbol arg 641.253k i/100ms
string arg 602.373k i/100ms
Calculating -------------------------------------
symbol arg 6.385M (± 0.6%) i/s - 32.063M in 5.022123s
string arg 6.023M (± 0.5%) i/s - 30.119M in 5.000717s
Comparison:
symbol arg: 6384545.4 i/s
string arg: 6023007.5 i/s - 1.06x slower
```
7 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #386, see there for benchmark script. The improvement isn't quite as large as for the other cases of this cop but it's still measurable. In addition it makes the code more uniform.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.