Require RuboCop 1.30+ as runtime dependency #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_ci_for_the_oldest_supported_rubocop_version
branch
from
6f5462c
to
ac418a3
Compare
This PR makes RuboCop Performance require RuboCop 1.30+ to fix some errors: https://github.com/rubocop/rubocop-performance/actions/runs/6966652446/job/18957154150 It introduces CI for the oldest RuboCop version still supported, implementing a workflow for regression testing that is similar to the one found a rubocop/rubocop-rails@c9acb7a.
koic
force-pushed
the
add_ci_for_the_oldest_supported_rubocop_version
branch
from
ac418a3
to
4c525a8
Compare
koic
changed the title
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Nov 27, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#388.
8 tasks
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Nov 28, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#388.
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Nov 28, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#388.
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Nov 29, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#388.
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Nov 29, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#388.
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Nov 29, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#388.
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Nov 29, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#388.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes RuboCop Performance require RuboCop 1.30+ to fix some errors:
https://github.com/rubocop/rubocop-performance/actions/runs/6966652446/job/18957154150
It introduces CI for the oldest RuboCop version still supported, implementing a workflow for regression testing that is similar to the one found a rubocop/rubocop-rails@c9acb7a.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.