Merge pull request #657 from sunny/migration-class-name-only-consider…

…-migration-classes Only consider migration classes for `MigrationClassName`
rubocop · Mar 15, 2022 · c39bff3 · c39bff3
2 parents 60f0e8d + ba2d060
commit c39bff3
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/changelog/fix_only_consider_migration_classes_for_migration_class_name.md b/changelog/fix_only_consider_migration_classes_for_migration_class_name.md
@@ -0,0 +1 @@
+* [#657](https://github.com/rubocop/rubocop-rails/pull/657): Only consider migration classes for `Rails/MigrationClassName`. ([@sunny][])
diff --git a/lib/rubocop/cop/rails/migration_class_name.rb b/lib/rubocop/cop/rails/migration_class_name.rb
@@ -20,10 +20,13 @@ module Rails
       #
       class MigrationClassName < Base
         extend AutoCorrector
+        include MigrationsHelper
 
         MSG = 'Replace with `%<corrected_class_name>s` that matches the file name.'
 
         def on_class(node)
+          return if in_migration?(node)
+
           snake_class_name = to_snakecase(node.identifier.source)
 
           basename = basename_without_timestamp_and_suffix

diff --git a/spec/rubocop/cop/rails/migration_class_name_spec.rb b/spec/rubocop/cop/rails/migration_class_name_spec.rb
@@ -10,6 +10,17 @@ class CreateUsers < ActiveRecord::Migration[7.0]
         end
       RUBY
     end
+
+    context 'when defining another class' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~RUBY, filename)
+          class CreateUsers < ActiveRecord::Migration[7.0]
+            class Article < ActiveRecord::Base
+            end
+          end
+        RUBY
+      end
+    end
   end
 
   context 'when the class name does not match its file name' do