Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1158] Rails/HasManyOrHasOneDependent reports false positive when has_many or has_one called on explicit receiver #1159

Conversation

samrjenkins
Copy link
Contributor

Fixes: #1158


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@samrjenkins samrjenkins force-pushed the fix-has-many-or-has-one-dependent-false-positive branch from ec1ace1 to 457c9d8 Compare October 17, 2023 09:30
@samrjenkins samrjenkins requested a review from koic October 17, 2023 09:50
@koic
Copy link
Member

koic commented Oct 17, 2023

Looks good to me. Can you squash your commits into one?

@samrjenkins
Copy link
Contributor Author

of course

…ive when has_many or has_one called on explicit receiver
@samrjenkins samrjenkins force-pushed the fix-has-many-or-has-one-dependent-false-positive branch from 98eb766 to f625711 Compare October 17, 2023 15:50
@koic koic merged commit e14def2 into rubocop:master Oct 18, 2023
10 checks passed
@koic
Copy link
Member

koic commented Oct 18, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants