Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for Rails/CompactBlank #1313

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jul 13, 2024

This PR fixes false positives for Rails/CompactBlank when using collection.reject!.

reject!(&:blank?) is not equivalent to compact_blank!:

{}.reject!(&:blank?)            # => nil
{}.reject! { |_k, v| v.blank? } # => nil
{}.compact_blank!               # => {}

This PR prioritizes safer behavior with plain hashes and arrays.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This PR fixes false positives for `Rails/CompactBlank`
when using `collection.reject!`.

`reject!(&:blank?)` is not equivalent to `compact_blank!`:

```ruby
{}.reject!(&:blank?)            # => nil
{}.reject! { |_k, v| v.blank? } # => nil
{}.compact_blank!               # => {}
```

This PR prioritizes safer behavior with plain hashes and arrays.
@koic koic merged commit 4464181 into rubocop:master Jul 14, 2024
14 checks passed
@koic koic deleted the fix_false_positive_for_rails_compact_blank branch July 14, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant