[Fix #210] Change enforced style to conditionals for Style/AndOr
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
change_enforced_style_to_conditionals
branch
2 times, most recently
from
6dbae58
to
76f1042
Compare
koic
force-pushed
the
change_enforced_style_to_conditionals
branch
from
76f1042
to
7cbceda
Compare
…dOr` Resolves rubocop#210. The following idioms exist for `return` and` raise` in Ruby. - `do_something and return` - `do_something || raise` And Rails will also show users the error message using this idiom. > `"redirect_to(...) and return\"` https://github.com/rails/rails/blob/v6.0.2.2/actionpack/lib/abstract_controller/rendering.rb#L10 This is the same for `render :action and return` and others. `Style/AndOr` cop default rule (`EnforcedStyle: always`) does seem to unmatch for these cases. I think these cases need to be accepted. So, this PR changes it to `EnforcedStyle: conditionals` at least in Rails. The enforced style cannot catch all cases, but probably the closest to solving the issue.
koic
force-pushed
the
change_enforced_style_to_conditionals
branch
from
7cbceda
to
83a32e1
Compare
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 12, 2020
This PR changes enforced style to `conditionals` for `Style/AndOr` cop. It forward porting from rubocop/rubocop-rails#224.
8 tasks
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
May 12, 2020
This PR changes enforced style to `conditionals` for `Style/AndOr` cop. It forward porting from rubocop/rubocop-rails#224.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #210.
The following idioms exist for
returnandraisein Ruby.do_something and returndo_something || raiseAnd Rails will also show users the error message using this idiom.
https://github.com/rails/rails/blob/v6.0.2.2/actionpack/lib/abstract_controller/rendering.rb#L10
This is the same for
render :action and returnand others.Style/AndOrcop default rule (EnforcedStyle: always) does seem to unmatch for these cases. I think these cases need to be accepted.So, this PR changes it to
EnforcedStyle: conditionalsat least in Rails. The enforced style cannot catch all cases, but probably the closest to solving the issue.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.