Fixes Rails/IndexBy correction when .to_h is separated by a newline #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the test cases included in this commit express well the
problem I'm trying to address, but running the auto-correction against
the following snippet of code:
Would yield:
The output isn't parseable/valid Ruby. I belive the problem has to do
with the fact that correction code assumes that the
.to_h
statement isalways grouped together (which isn't true).
The proposed solution was to compute the trailing characters to be
stripped by subtracting the end position of the map block (the
}
character)from end position of the whole expression.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.