Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #300] Fix Rails/RenderInline error on variable key in render options #303

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes: #300


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@tejasbubane tejasbubane changed the title [Fixes #300] Fix Rails/RenderInline error on variable key in render options [Fix #300] Fix Rails/RenderInline error on variable key in render options Jul 21, 2020
@eugeneius
Copy link
Contributor

It's possible to write this cop entirely as a node pattern, which would also fix the bug:

        def_node_matcher :render_with_inline_option?, <<~PATTERN
          (send nil? :render (hash <(pair {(sym :inline) (str "inline")} _) ...>))
        PATTERN

        def on_send(node)
          add_offense(node) if render_with_inline_option?(node)
        end

@koic
Copy link
Member

koic commented Jul 23, 2020

@tejasbubane Can you update this PR?

@tejasbubane
Copy link
Contributor Author

@tejasbubane Can you update this PR?

@koic Done.

@koic koic merged commit 214410f into rubocop:master Jul 24, 2020
@koic
Copy link
Member

koic commented Jul 24, 2020

Thanks!

@tejasbubane tejasbubane deleted the fix-300 branch July 24, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/RenderInline: undefined method `value'
3 participants