Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #338][Fix #350] Fix a false positive for Rails/IndexBy and Rails/IndexWith #353

Merged
merged 1 commit into from Sep 10, 2020

Conversation

eugeneius
Copy link
Contributor

If the each_with_object hash is used in the transformed key or value, Rails/IndexBy or Rails/IndexWith can't be used.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…exBy and Rails/IndexWith

If the `each_with_object` hash is used in the transformed key or value,
`Rails/IndexBy` or `Rails/IndexWith` can't be used.
@koic
Copy link
Member

koic commented Sep 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants