[Fix #669] Fix a false positive for Rails/TransactionExitStatement
#674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement` Fixes rubocop#669. This PR fixes a false positive for `Rails/TransactionExitStatement` when `return` is used in `rescue`.
koic
deleted the
fix_false_positive_for_rails_transaction_exit_statement
branch
|
@koic I don't see why this is a false positive; that return is definitely inside the transaction block, and will cause exactly the sort of unwind that has changed behaviour. (To me, such a "rescue and then return" pattern is exactly the case one should worry about the most!) |
|
This is my mistake and will revert this change. @matthewd Thank you for mentioning it! |
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 23, 2022
Follow up rubocop#674 (comment) Revert "[Fix rubocop#669] Fix a false positive for `Rails/TransactionExitStatement`" This reverts commit d9ec02d. So this PR fixes a false negative for `Rails/TransactionExitStatement` when `return` is used in `rescue`.
This was referenced Apr 23, 2022
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 23, 2022
Follow up rubocop#674 (comment) Revert "[Fix rubocop#669] Fix a false positive for `Rails/TransactionExitStatement`" This reverts commit d9ec02d and tweak a spec. So this PR fixes a false negative for `Rails/TransactionExitStatement` when `return` is used in `rescue`.
|
I think this might address the issue: #695 |
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 27, 2022
Follow up rubocop#674 (comment) Revert "[Fix rubocop#669] Fix a false positive for `Rails/TransactionExitStatement`" This reverts commit d9ec02d and add an example, tweak a spec. So this PR fixes a false negative for `Rails/TransactionExitStatement` when `return` is used in `rescue`.
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 27, 2022
Follow up rubocop#674 (comment) Revert "[Fix rubocop#669] Fix a false positive for `Rails/TransactionExitStatement`" This reverts commit d9ec02d and add an example, tweak a spec. So this PR fixes a false negative for `Rails/TransactionExitStatement` when `return` is used in `rescue`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #669.
This PR fixes a false positive for
Rails/TransactionExitStatementwhenreturnis used inrescue.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.and description in grammatically correct, complete sentences.