Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specs to use the expect_correction helper #734

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

Darhazer
Copy link
Member

While working on a fix for #712 I've noticed that the specs of Rails/Delegate use the old-fashioned auto-correction validation. I've updated everywhere that it doesn't make sense to use autocorrect_source (some cops still use it as they have additional specs on the correction and there is little gain in concerting those; and others because of the shared_examples usage)


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit da37010 into master Jun 27, 2022
@koic
Copy link
Member

koic commented Jun 27, 2022

Thanks!

@Darhazer Darhazer deleted the refactor-correction-specs branch June 27, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants