Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#78] Create EnumHash Cop #94

Merged
merged 1 commit into from
Jul 25, 2019
Merged

[#78] Create EnumHash Cop #94

merged 1 commit into from
Jul 25, 2019

Conversation

santib
Copy link
Contributor

@santib santib commented Jul 24, 2019

Closes #78.

Implement EnumHash Cop.
Prefer hash syntax over array syntax for enum declarations.

@santib santib force-pushed the add-hashenum-cop branch 2 times, most recently from 48f2ecb to 8808dab Compare July 24, 2019 21:00
@andyw8
Copy link
Contributor

andyw8 commented Jul 24, 2019

Not needed now, but it would be nice to have an autocorrect this in the future.

@santib
Copy link
Contributor Author

santib commented Jul 24, 2019

Not needed now, but it would be nice to have an autocorrect this in the future.

@andyw8 We splitted the work in two PRs because we didn't know if we were going to have time to do both and also to make code review easier. Here is the autocorrect PR #95 . Let us know if you prefer to have them being just one PR. Thanks for reviewing BTW 😄

@brunvez brunvez force-pushed the add-hashenum-cop branch 2 times, most recently from a5ea0b2 to 69b69d0 Compare July 24, 2019 22:25
@andyw8
Copy link
Contributor

andyw8 commented Jul 25, 2019

@andyw8 We splitted the work in two PRs because we didn't know if we were going to have time to do both and also to make code review easier. Here is the autocorrect PR #95 . Let us know if you prefer to have them being just one PR. Thanks for reviewing BTW 😄

Awesome. I think it's fine to have them as separate PRs.

config/default.yml Outdated Show resolved Hide resolved
config/default.yml Outdated Show resolved Hide resolved
@santib santib changed the title [#78] Create HashEnum Cop [#78] Create EnumHash Cop Jul 25, 2019
@koic koic merged commit 7b55e00 into rubocop:master Jul 25, 2019
@koic
Copy link
Member

koic commented Jul 25, 2019

Thanks!

@santib santib deleted the add-hashenum-cop branch July 25, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Cop: Explicit enum definition
3 participants