Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negative in RSpec/ExpectChange with block style #1143

Closed
pirj opened this issue Apr 18, 2021 · 0 comments · Fixed by #1152
Closed

False negative in RSpec/ExpectChange with block style #1143

pirj opened this issue Apr 18, 2021 · 0 comments · Fixed by #1152
Labels

Comments

@pirj
Copy link
Member

pirj commented Apr 18, 2021

Given:

RSpec/ExpectChange:
  EnforcedStyle: block

the cop is missing the following:

      expect { paint_users! }
        .to change(users.green, :count).by(1)
        .and change(PaintedAdmins.where('color ilike ?', color), :count).by(0)
@pirj pirj added the bug label Apr 18, 2021
tejasbubane added a commit to tejasbubane/rubocop-rspec that referenced this issue May 19, 2021
tejasbubane added a commit to tejasbubane/rubocop-rspec that referenced this issue May 19, 2021
tejasbubane added a commit to tejasbubane/rubocop-rspec that referenced this issue May 19, 2021
tejasbubane added a commit to tejasbubane/rubocop-rspec that referenced this issue May 19, 2021
tejasbubane added a commit to tejasbubane/rubocop-rspec that referenced this issue May 21, 2021
tejasbubane added a commit to tejasbubane/rubocop-rspec that referenced this issue May 21, 2021
tejasbubane added a commit to tejasbubane/rubocop-rspec that referenced this issue May 21, 2021
tejasbubane added a commit to tejasbubane/rubocop-rspec that referenced this issue May 24, 2021
pirj pushed a commit that referenced this issue May 25, 2021
pirj pushed a commit that referenced this issue May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant