Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RSpec/Capybara/SpecificMatcher] False-positive with pseudo-classes #1351

Closed
boris-petrov opened this issue Aug 3, 2022 · 1 comment · Fixed by #1361
Closed

[RSpec/Capybara/SpecificMatcher] False-positive with pseudo-classes #1351

boris-petrov opened this issue Aug 3, 2022 · 1 comment · Fixed by #1361

Comments

@boris-petrov
Copy link 

expect(page).to have_selector('button:first-of-type:focus')

This gives a warning but I don't think it's possible to express this with have_button.

cc @ydah
@ydah
Copy link
Member

ydah commented Aug 4, 2022 •
edited
Loading

Indeed it is. Thank you so much @boris-petrov

I guess we need to consider the cases that cannot be replaced by pseudo-classes.
It may take some time, but I will work on it.

ydah added a commit to ydah/rubocop-rspec that referenced this issue Aug 16, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
295f367 
…-classes

Resolve: rubocop#1351
@ydah ydah mentioned this issue Aug 16, 2022
Merged
5 tasks
ydah added a commit to ydah/rubocop-rspec that referenced this issue Aug 25, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
9bafb50 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Aug 30, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
d349fc8 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Sep 1, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
e33a2ba 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Sep 1, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
808391d 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Sep 1, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
8f8e809 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Sep 1, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
a1d54b8 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Sep 2, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
bddd4d8 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Sep 2, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
2fa8f2a 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Sep 4, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
f66accc 
…-classes

Resolve: rubocop#1351
ydah added a commit to ydah/rubocop-rspec that referenced this issue Sep 7, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
3660fd6 
…-classes

Resolve: rubocop#1351
pirj pushed a commit to rubocop/rubocop-capybara that referenced this issue Dec 29, 2022
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
948a329 
…-classes

Resolve: rubocop/rubocop-rspec#1351
ydah added a commit to rubocop/rubocop-factory_bot that referenced this issue Apr 13, 2023
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
e1a6381 
…-classes

Resolve: rubocop/rubocop-rspec#1351
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this issue Mar 27, 2024
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
b696639 
…-classes

Resolve: rubocop/rubocop-rspec#1351
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this issue Mar 27, 2024
@ydah
Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo…
dd75342 
…-classes

Resolve: rubocop/rubocop-rspec#1351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo-classes ydah/rubocop-rspec
2 participants
@boris-petrov @ydah