Add style guide references #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
1101-align-with-style-guide
branch
2 times, most recently
from
29d7fc6
to
45359c3
Compare
pirj
force-pushed
the
1101-align-with-style-guide
branch
from
45359c3
to
0e81581
Compare
pirj
commented
Jan 4, 2022
pirj
commented
Jan 4, 2022
pirj
commented
Jan 5, 2022
pirj
force-pushed
the
1101-align-with-style-guide
branch
from
0e81581
to
a26e98f
Compare
pirj
commented
Jan 5, 2022
config/default.yml
Outdated
|
|
||
| RSpec/AnyInstance: | ||
| Description: Check that instances are not being stubbed globally. | ||
| Enabled: true | ||
| VersionAdded: '1.4' | ||
| StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/AnyInstance | ||
| StyleGuide: "#any_instance_of" |
There was a problem hiding this comment.
I could only find 23 cops that enforce style guide guidelines.
|
Green 🍏 |
|
@bquorning @Darhazer WDYT? |
pirj
force-pushed
the
1101-align-with-style-guide
branch
from
a26e98f
to
7b4fcfe
Compare
Darhazer
reviewed
Jan 12, 2022
| @@ -104,6 +104,7 @@ end | |||
|
|
|||
| === References | |||
|
|
|||
| * https://rubystyle.guide#any_instance_of | |||
There was a problem hiding this comment.
Those are generated with the wrong domain
There was a problem hiding this comment.
I see other extensions are not using short links: https://github.com/rubocop/rubocop-rails/blob/0a902551d34f192ea3b24d7bdbbc90349d1eb9ef/config/default.yml#L63. Let me fix it real quick.
There was a problem hiding this comment.
Fixed, thanks for noticing 👍
pirj
force-pushed
the
1101-align-with-style-guide
branch
from
bf4ebd5
to
f51d12c
Compare
pirj
force-pushed
the
1101-align-with-style-guide
branch
from
f51d12c
to
0e7beb6
Compare
Darhazer
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addressesfixes #1101. I believe #1101 raised the bar too high, and this PR is sufficient to a desired state.☣️⚠️ This will affect the list of cops that RuboCop will run with
--only-guide-copsoption.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).