Proof of concept separation of departments

[pirj]

See discussion

🔎 better viewed without indentation changes

I went too far, as renaming cops is a breaking change:

.rubocop_todo.yml: RSpec/FactoryBot/ConsistentParenthesesStyle has the wrong namespace - should be FactoryBot
.rubocop_todo.yml: RSpec/FactoryBot/CreateList has the wrong namespace - should be FactoryBot
.rubocop_todo.yml: RSpec/FactoryBot/FactoryClassName has the wrong namespace - should be FactoryBot
Error: Ambiguous cop name `RSpec/Rails/HttpStatus` used in /Users/pirj/source/test/.rubocop_todo.yml needs department qualifier. Did you mean Rails/HttpStatus or RSpecRails/HttpStatus?

This way it would be a breaking change. And we could only afford this in 3.0.
But then, when we'll decide to actually extract them, we'd have to release 4.0.
And when RuboCop 2.0 is finally released, and if we decide not to sync our 3.0 and 2.0 with it, we'll have to release 5.0. Just because they will enable their pending cops.

What do you think of such a series of major updates?

Not done

1. RuboCop::RSpec::FactoryBot::Language is used by both the extracted (lib/rubocop/cop/factory_bot/create_list.rb, lib/rubocop/cop/factory_bot/consistent_parentheses_style.rb) and the remaining lib/rubocop/cop/rspec/factory_bot/syntax_methods.rb cops.

2. Too lazy to fix one last spec

---

Before submitting the PR make sure the following are checked:

• [+] Feature branch is up-to-date with master (if not - rebase it).
• [-] Squashed related commits together.
• [-] Added tests.
• [-] Updated documentation.
• [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• [+/-] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

Explanation why this is a breaking change

[pirj]

require_relative 'rubocop/rspec/factory_bot'

above is needed by both the extracted (RSpec-agnostic) and the remaining (RSpec-specific) FactoryBot cops.

[pirj]

Any idea why this was needed?

[pirj]

Replaced with an argument YARD::Registry.all(:class).

[pirj]

We only load our classes using a glob, why would we check if it's really ours?

[pirj]

Not perfect. Could probably be '{capybara,factory_bot,rspec,rspec/capybara,rspec/factory_bot,rspec/rails,rspec-rails}, but it's not platform-independent. Do we care about other platforms (that one with \ file separator!) running our tests?

[pirj]

I'm closing this one and will make another iteration going further, with putting all the prospective gems in separate directories, with own gemspecs, lib, spec etc.