Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump actions/checkout from 3 to 4 #1707

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Bump actions/checkout from 3 to 4 #1707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codespell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: CodeSpell
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add

        with:
          show-progress: false

to have less noise in the CI logs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's now the default
image
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://github.com/rubocop/rubocop-rspec/actions/runs/6076842370/job/16485526462:
image
You are correct. But it looks like a bug. Notice how it says show-progress: true in the list of run options, and there is no --progress flag in the git command?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue: actions/checkout#1453

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

- name: CodeSpell
uses: codespell-project/actions-codespell@master
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/danger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: Danger
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: ruby/setup-ruby@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: Yamllint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Yamllint
uses: karancode/yamllint-github-action@master
with:
Expand All @@ -22,7 +22,7 @@ jobs:
name: Mdformat
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Mdformat
uses: ydah/mdformat-action@main
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
name: Confirm config and documentation
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: "3.2"
Expand All @@ -38,7 +38,7 @@ jobs:
- spec
name: "Ruby ${{ matrix.ruby }}: ${{ matrix.task }}"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: "${{ matrix.ruby }}"
Expand All @@ -49,7 +49,7 @@ jobs:
runs-on: ubuntu-latest
name: "Test coverage"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: "3.2"
Expand All @@ -65,7 +65,7 @@ jobs:
- spec
name: "Edge RuboCop: ${{ matrix.task }}"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use latest RuboCop from `master`
run: |
echo "gem 'rubocop', github: 'rubocop-hq/rubocop'" > Gemfile.local
Expand All @@ -79,7 +79,7 @@ jobs:
runs-on: ubuntu-latest
name: RSpec 4
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use latest RSpec 4 from `4-0-dev` branch
run: |
sed -e '/rspec/d' -i Gemfile
Expand Down