RSpec/MetadataStyle: Fix false positive for multiple strings preceding metadata

[franzliedke]

This fixes a false positive in an example group like the following:

      response "404", "unauthorized access", api_docs: false do
        let(:authorization) { another_user.token }

        run_test!
      end

(This uses DSL from the rswag gem.)

Fixes #1714.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[franzliedke]

Drive-by typo fix 😇

[franzliedke]

I first fixed this in the rspec_metadata matcher in lib/rubocop/cop/rspec/mixin/metadata.rb (see individual commits), but this made one test for the RSpec/SortMetadata cop fail. Looking at that cop, it seems to respect many more interesting cases, such as dynamic arguments, which could probably create more false positives in the MetadataStyle cop.

Example:

context "something dynamic based on", variable do
  # ...
end

I decided not to dive into these cases and leave it to the AST matcher experts. (They may also be outside the scope of this PR, as this cop didn't worry about them so far.) Feel free to amend this PR if you see an obvious improvement.

[bquorning]

I suspect the real solution in mixin/metadata.rb would be to separate which metadata can be passed to #Examples.all vs #ExampleGroups.all, but I’m not sure I want to go down that rabbit hole 😅 The suggested fix works for me, too.

[franzliedke]

This should fix the tests.

[bquorning]

I suspect the real solution in mixin/metadata.rb would be to separate which metadata can be passed to #Examples.all vs #ExampleGroups.all, but I’m not sure I want to go down that rabbit hole 😅 The suggested fix works for me, too.

[franzliedke]

@bquorning Thanks so much for the review, I appreciate it! Do I need to do something else (like squashing the commits), or just be patient? 😇

[pirj]

Thank you!
I had some ideas how to improve node patterns, but will attempt separately.

[bquorning]

Do I need to do something else (like squashing the commits), or just be patient? 😇

Valid question 😅 If you squash the last 3 commits together, I’ll merge it.

[franzliedke]

@bquorning Consider it done. 👍🏼

[bquorning]

Thank you 👍🏼