Bugfix for custom HTTP status codes #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Rack isn't loaded, the cop just isn't available.
When Rails/HttpStatus is configured to use `symbolic` style, a custom HTTP
status code (e.g. 550) that couldn't be found in Rack's `SYMBOL_TO_STATUS_CODE`
hash would result in an error:
^^^ Prefer `nil` over `550` to describe HTTP status code.
Darhazer
approved these changes
Feb 24, 2018
|
I was thinking the same - this false positive can be fixed only if rack is available (and generally whoever uses this cop will have it available). Not loading the cop at all, when there is no rack available, seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #560.
When Rails/HttpStatus is configured to use
symbolicstyle, a custom HTTP status code (e.g. 550) that couldn't be found in Rack'sSYMBOL_TO_STATUS_CODEhash would result in an error:This is solved by allowing integer values that are not present in
SYMBOL_TO_STATUS_CODEwhen using thesymbolicstile.For this to work, I found that the
Rails/HttpStatuscop couldn’t continue to be flexible in its dependency on Rack. But we cannot allow rubocop-rspec to have a hard dependency on Rack either. So I’m suggesting that werescue LoadErroreither in the cop itself, or in the rspec_cops.rb file, right afterrequire_relative 'rspec/rails/http_status'.Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) is passing.