-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Rails department to RSpecRails #834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks a lot!
Add RSpecRails -> rspec_rails pair.
@bquorning any chance to get this merged? :D |
I’m split on this one. It seems like a fix of the symptoms instead of a fix of the underlying problem. @Darhazer and @dgollahon, do you have any input on this? |
I agree that these are two different namespaces. And I had proposal of overriding default cop badge: |
Is there still interest in fixing this cop? Right now it causes a lot of frustration: depending on the order of requires either one cop will be working or the other... |
It seems like the ideal approach would be to fix the way departments/plugins are handled (presumably in I defer to @bquorning / @Darhazer, but this strikes me as reasonable for now. |
After giving it another thought I tend to side with you guys, it needs to be fixed on RuboCop side. |
@pirj Yeah, probably we should. |
Rubocop provides Rails/HttpStatus cop to lint
render
(and its friends) methods in controllers. That causes conflicts with RSpec/Rails/HttpStatus and makes one of them dysfunctional depending onrequire
order.This patchset renames
RuboCop::Cop::RSpec::Rails::HttpStatus
toRuboCop::Cop::RSpec::RSpecRails::HttpStatus
, which both resolves namespacing conflict and makes department name better match with gem it aims to (rspec-rails).Resolves: #611