Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary fixes in #14 #45

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Remove temporary fixes in #14 #45

merged 1 commit into from
Jun 19, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jun 19, 2024

remove temporary hack by #14


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

remove temporary hack by #14
@ydah ydah requested a review from a team as a code owner June 19, 2024 09:37
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@ydah ydah merged commit 7a26689 into master Jun 19, 2024
25 checks passed
@ydah ydah deleted the remove-fixme branch June 19, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants