Remove ColumnDefault cop #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberdelia
force-pushed
the
its-gotten-better
branch
from
f0acf11
to
0459611
Compare
fdr
added a commit
to ubicloud/ubicloud
that referenced
this pull request
Nov 14, 2023
This is likely to become the default in a new version of rubocop-sequel. It was intended to prevent full-table rewrites, which new versions of Postgres avoid in common cases and we don't care particularly much about anyway: rubocop/rubocop-sequel#32 Eventually setting this explicitly to false will be obsolete, once this commit reaches a release: rubocop/rubocop-sequel#33
fdr
added a commit
to ubicloud/ubicloud
that referenced
this pull request
Nov 14, 2023
This is likely to become the default in a new version of rubocop-sequel. It was intended to prevent full-table rewrites, which new versions of Postgres avoid in common cases and we don't care particularly much about anyway: rubocop/rubocop-sequel#32 Eventually setting this explicitly to false will be obsolete, once this commit reaches a release: rubocop/rubocop-sequel#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ColumnDefault cop since it's mostly outdated advice, see #32.