Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to GitHub Actions #3

Merged
merged 4 commits into from May 18, 2022
Merged

Migrate CI to GitHub Actions #3

merged 4 commits into from May 18, 2022

Conversation

petergoldstein
Copy link

In addition to introducing a GitHub Actions configuration this PR:

  1. Updates the minimum Ruby allowed for the gem to 2.5
  2. Makes a similar change for the RequiredRubyVersion in the Rubocop config.

This minimum version change has been discussed with the maintainer.

Runs green on my fork.

Commit to Ruby 2.5+
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@bquorning
Copy link

Two more things:

  1. Shouldn’t we also remove .travis.yml in this PR?
  2. There are a couple of RUBY_VERSION checks in ./Appraisals which are no longer necessary.

This was referenced May 18, 2022
@mikegee
Copy link
Collaborator

mikegee commented May 18, 2022

i'm struggling to figure out how to make GitHub run these actions. does it need merged first?

@bquorning
Copy link

Yes, I think this first time, you need to merge it before it runs.

@petergoldstein
Copy link
Author

@mikegee I believe so.

@mikegee mikegee merged commit 0a25f3c into rubocop:master May 18, 2022
@mikegee
Copy link
Collaborator

mikegee commented May 18, 2022

Thanks!

@petergoldstein
Copy link
Author

And the actions are running on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants