forked from covermymeds/rubocop-thread_safety
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI to GitHub Actions #3
Merged
mikegee
merged 4 commits into
rubocop:master
from
petergoldstein:feature/migrate_ci_to_github_actions
May 18, 2022
Merged
Migrate CI to GitHub Actions #3
mikegee
merged 4 commits into
rubocop:master
from
petergoldstein:feature/migrate_ci_to_github_actions
May 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit to Ruby 2.5+
bquorning
approved these changes
May 17, 2022
bquorning
reviewed
May 18, 2022
bquorning
reviewed
May 18, 2022
Two more things:
|
This was referenced May 18, 2022
Merged
bquorning
approved these changes
May 18, 2022
i'm struggling to figure out how to make GitHub run these actions. does it need merged first? |
Yes, I think this first time, you need to merge it before it runs. |
@mikegee I believe so. |
Thanks! |
And the actions are running on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to introducing a GitHub Actions configuration this PR:
This minimum version change has been discussed with the maintainer.
Runs green on my fork.