Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.3 to CI matrix #30

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Conversation

m-nakamura145
Copy link

This PR adds Ruby 3.3 to CI matrix.

@mikegee
Copy link
Collaborator

mikegee commented Dec 31, 2023

Thank you for the contribution! ❤️

Looks like we need a bit of maintenance on that Lint check. There's a bunch of warnings too. (I'm a little embarrassed.)

Do you feel like helping on those?

@m-nakamura145
Copy link
Author

@mikegee Of course! Should I fix the tests where Rubocop warnings were issued in this Pull Request?

@mikegee
Copy link
Collaborator

mikegee commented Dec 31, 2023

I'm glad you are willing to help. Separate or together are both fine with me. Those fixes aren't related to this PR, but you could put them together as "maintenance" in one PR, if you want.

@m-nakamura145
Copy link
Author

@mikegee Thank you! I will add new commits to this Pull Request. Is it okay to proceed with the approach of fixing the tests that generated warnings, without changing the Rubocop RSpec/ExampleLength rules?"

@mikegee
Copy link
Collaborator

mikegee commented Dec 31, 2023

🤔 Looks like RSpec/ExampleLength wants our examples 5 or fewer lines. I don't think that's worth rewriting a lot of specs. I think we should set a project setting for that cop to allow 11 or whatever makes it stop complaining. 11 line examples don't seem that bad to me.

But, I'm happy to accept any approach you want.

@m-nakamura145
Copy link
Author

@mikegee I agree with your opinion. I have added the RSpec/ExampleLength setting to .rubocop.yml.
ca8ffb7

@mikegee mikegee merged commit eabf6f5 into rubocop:master Dec 31, 2023
23 checks passed
@mikegee
Copy link
Collaborator

mikegee commented Dec 31, 2023

Thanks so much!

@m-nakamura145 m-nakamura145 deleted the update-ci-matrix branch December 31, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants