Skip to content

Commit

Permalink
Cut 1.55.1
Browse files Browse the repository at this point in the history
  • Loading branch information
bbatsov committed Jul 31, 2023
1 parent 89c3045 commit 000ae57
Show file tree
Hide file tree
Showing 9 changed files with 53 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ output by `rubocop -V`, include them as well. Here's an example:

```
$ [bundle exec] rubocop -V
1.55.0 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2) [x86_64-linux]
1.55.1 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2) [x86_64-linux]
- rubocop-performance 1.9.1
- rubocop-rspec 2.0.0
```
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

## master (unreleased)

## 1.55.1 (2023-07-31)

### Bug fixes

* [#12068](https://github.com/rubocop/rubocop/pull/12068): Fix a false positive for `Style/ReturnNilInPredicateMethodDefinition` when the last method argument in method definition is `nil`. ([@koic][])
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ do so.

```console
$ rubocop -V
1.55.0 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2) [x86_64-linux]
1.55.1 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2) [x86_64-linux]
- rubocop-performance 1.9.1
- rubocop-rspec 2.0.0
```
Expand Down
2 changes: 1 addition & 1 deletion docs/antora.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ name: rubocop
title: RuboCop
# We always provide version without patch here (e.g. 1.1),
# as patch versions should not appear in the docs.
version: ~
version: '1.55'
nav:
- modules/ROOT/nav.adoc
18 changes: 17 additions & 1 deletion docs/modules/ROOT/pages/cops_bundler.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,24 @@ gem 'rubocop'
gem 'rubocop'
gem 'rspec'
----

==== TreatCommentsAsGroupSeparators: true (default)

# good only if TreatCommentsAsGroupSeparators is true
[source,ruby]
----
# good
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'
----

==== TreatCommentsAsGroupSeparators: false

[source,ruby]
----
# bad
# For code quality
gem 'rubocop'
# For tests
Expand Down
18 changes: 17 additions & 1 deletion docs/modules/ROOT/pages/cops_gemspec.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,24 @@ spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'
----

==== TreatCommentsAsGroupSeparators: true (default)

# good only if TreatCommentsAsGroupSeparators is true
[source,ruby]
----
# good
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'
----

==== TreatCommentsAsGroupSeparators: false

[source,ruby]
----
# bad
# For code quality
spec.add_dependency 'rubocop'
# For tests
Expand Down
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/cops_layout.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -6239,7 +6239,7 @@ foo &.bar
foo &. bar
foo &. bar&. buzz
RuboCop:: Cop
RuboCop:: Cop:: Cop
RuboCop:: Cop:: Base
:: RuboCop::Cop
# good
Expand All @@ -6251,7 +6251,7 @@ foo
foo&.bar
foo&.bar&.buzz
RuboCop::Cop
RuboCop::Cop::Cop
RuboCop::Cop::Base
::RuboCop::Cop
----

Expand Down
2 changes: 1 addition & 1 deletion lib/rubocop/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module RuboCop
# This module holds the RuboCop version information.
module Version
STRING = '1.55.0'
STRING = '1.55.1'

MSG = '%<version>s (using Parser %<parser_version>s, ' \
'rubocop-ast %<rubocop_ast_version>s, ' \
Expand Down
11 changes: 11 additions & 0 deletions relnotes/v1.55.1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
### Bug fixes

* [#12068](https://github.com/rubocop/rubocop/pull/12068): Fix a false positive for `Style/ReturnNilInPredicateMethodDefinition` when the last method argument in method definition is `nil`. ([@koic][])
* [#12082](https://github.com/rubocop/rubocop/issues/12082): Fix an error for `Lint/UselessAssignment` when a variable is assigned and unreferenced in `for` with multiple variables. ([@koic][])
* [#12079](https://github.com/rubocop/rubocop/issues/12079): Fix an error for `Style/MixinGrouping` when mixin method has no arguments. ([@koic][])
* [#11637](https://github.com/rubocop/rubocop/pull/11637): Correct Rubocop for `private_class_method` method documentation. ([@bigzed][])
* [#12070](https://github.com/rubocop/rubocop/pull/12070): Fix false positive in `Style/ArgumentsForwarding` when receiver forwards args/kwargs. ([@owst][])

[@koic]: https://github.com/koic
[@bigzed]: https://github.com/bigzed
[@owst]: https://github.com/owst

0 comments on commit 000ae57

Please sign in to comment.