Merge pull request #12772 from Earlopain/fix-error-for-style-class-vars

Fix an error for `Style/ClassVars` when calling `class_variable_set` without arguments
rubocop · Mar 10, 2024 · 409c5a0 · 409c5a0
2 parents 5ee786d + 94c17b8
commit 409c5a0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/changelog/fix_an_error_for_style_class_vars.md b/changelog/fix_an_error_for_style_class_vars.md
@@ -0,0 +1 @@
+* [#12772](https://github.com/rubocop/rubocop/pull/12772): Fix an error for `Style/ClassVars` when calling `class_variable_set` without arguments. ([@earlopain][])
diff --git a/lib/rubocop/cop/style/class_vars.rb b/lib/rubocop/cop/style/class_vars.rb
@@ -54,9 +54,9 @@ def on_cvasgn(node)
         end
 
         def on_send(node)
-          add_offense(
-            node.first_argument, message: format(MSG, class_var: node.first_argument.source)
-          )
+          return unless (first_argument = node.first_argument)
+
+          add_offense(first_argument, message: format(MSG, class_var: first_argument.source))
         end
       end
     end

diff --git a/spec/rubocop/cop/style/class_vars_spec.rb b/spec/rubocop/cop/style/class_vars_spec.rb
@@ -28,4 +28,8 @@ class TestClass; end
   it 'does not register an offense for class variable usage' do
     expect_no_offenses('@@test.test(20)')
   end
+
+  it 'registers no offense for class variable set without arguments' do
+    expect_no_offenses('class_variable_set')
+  end
 end