Skip to content

Commit

Permalink
[Fix #2260] Disable Style/StringMethods by default
Browse files Browse the repository at this point in the history
The cop is likely to generate false positives, so it's better
to have it disabled by default.
  • Loading branch information
bbatsov committed Sep 19, 2015
1 parent 9acc967 commit 44af764
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -18,6 +18,7 @@

* [#2248](https://github.com/bbatsov/rubocop/issues/2248): Allow block-pass in `Style/AutoResourceCleanup`. ([@lumeet][])
* [#2258](https://github.com/bbatsov/rubocop/pull/2258): `Style/Documentation` will exclude test directories by default. ([@rrosenblum][])
* [#2260](https://github.com/bbatsov/rubocop/issues/2260): Disable `Style/StringMethods` by default. ([@bbatsov][])

## 0.34.1 (09/09/2015)

Expand Down
4 changes: 4 additions & 0 deletions config/disabled.yml
Expand Up @@ -57,6 +57,10 @@ Style/Send:
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#prefer-public-send'
Enabled: false

Style/StringMethods:
Description: 'Checks if configured preferred methods are used over non-preferred.'
Enabled: false

Style/SymbolArray:
Description: 'Use %i or %I for arrays of symbols.'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-i'
Expand Down
4 changes: 0 additions & 4 deletions config/enabled.yml
Expand Up @@ -701,10 +701,6 @@ Style/StringLiteralsInInterpolation:
strings match the configured preference.
Enabled: true

Style/StringMethods:
Description: 'Checks if configured preferred methods are used over non-preferred.'
Enabled: true

Style/StructInheritance:
Description: 'Checks for inheritance from Struct.new.'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-extend-struct-new'
Expand Down

0 comments on commit 44af764

Please sign in to comment.