Refactoring

rubocop · Sep 14, 2017 · 44fa554 · 44fa554
1 parent 9024c8b
commit 44fa554
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lib/rubocop/cop/lint/unneeded_with_index.rb b/lib/rubocop/cop/lint/unneeded_with_index.rb
@@ -48,7 +48,7 @@ def on_block(node)
         def autocorrect(node)
           lambda do |corrector|
             unneeded_with_index?(node) do |send|
-              if each_with_index_method?(node)
+              if send.method_name == :each_with_index
                 corrector.replace(send.loc.selector, 'each')
               else
                 corrector.remove(send.loc.selector)
@@ -61,16 +61,16 @@ def autocorrect(node)
         private
 
         def message(node)
-          each_with_index_method?(node) ? MSG_EACH_WITH_INDEX : MSG_WITH_INDEX
+          if node.method_name == :each_with_index
+            MSG_EACH_WITH_INDEX
+          else
+            MSG_WITH_INDEX
+          end
         end
 
         def with_index_range(send)
           range_between(send.loc.selector.begin_pos, send.loc.selector.end_pos)
         end
-
-        def each_with_index_method?(node)
-          node.children.first.children.last == :each_with_index
-        end
       end
     end
   end