Make Style/PreferredHashMethods aware of safe navigation operator

rubocop · Feb 9, 2019 · 5fc114c · 5fc114c
1 parent a285622
commit 5fc114c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/rubocop/cop/style/preferred_hash_methods.rb b/lib/rubocop/cop/style/preferred_hash_methods.rb
@@ -41,6 +41,7 @@ def on_send(node)
 
           add_offense(node, location: :selector)
         end
+        alias on_csend on_send
 
         def autocorrect(node)
           lambda do |corrector|

diff --git a/spec/rubocop/cop/style/preferred_hash_methods_spec.rb b/spec/rubocop/cop/style/preferred_hash_methods_spec.rb
@@ -24,6 +24,15 @@
       RUBY
     end
 
+    context 'when using safe navigation operator', :ruby23 do
+      it 'registers an offense for has_value? with one arg' do
+        expect_offense(<<-RUBY.strip_indent)
+        o&.has_value?(o)
+           ^^^^^^^^^^ Use `Hash#value?` instead of `Hash#has_value?`.
+        RUBY
+      end
+    end
+
     it 'accepts has_value? with no args' do
       expect_no_offenses('o.has_value?')
     end