Skip to content

Commit

Permalink
Rename variable in InvertibleUnlessCondition
Browse files Browse the repository at this point in the history
This change was meant to be in #12711.
  • Loading branch information
sambostock authored and bbatsov committed Feb 29, 2024
1 parent f151524 commit 87b3b4d
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions lib/rubocop/cop/style/invertible_unless_condition.rb
Original file line number Diff line number Diff line change
Expand Up @@ -105,19 +105,22 @@ def preferred_send_condition(node) # rubocop:disable Metrics/CyclomaticComplexit
receiver_source = node.receiver&.source
return receiver_source if node.method?(:!)

receive = receiver_source ? "#{receiver_source}." : '' # receiver may be implicit (self)
# receiver may be implicit (self)
dotted_receiver_source = receiver_source ? "#{receiver_source}." : ''

inverse_method_name = inverse_methods[node.method_name]
return "#{receive}#{inverse_method_name}" unless node.arguments?
return "#{dotted_receiver_source}#{inverse_method_name}" unless node.arguments?

argument_list = node.arguments.map(&:source).join(', ')
if node.operator_method?
return "#{receiver_source} #{inverse_method_name} #{argument_list}"
end

return "#{receive}#{inverse_method_name}(#{argument_list})" if node.parenthesized?
if node.parenthesized?
return "#{dotted_receiver_source}#{inverse_method_name}(#{argument_list})"
end

"#{receive}#{inverse_method_name} #{argument_list}"
"#{dotted_receiver_source}#{inverse_method_name} #{argument_list}"
end

def preferred_logical_condition(node)
Expand Down

0 comments on commit 87b3b4d

Please sign in to comment.