[Fix #11974] Fix an error for Style/RedundantCurrentDirectoryInPath

Fixes #11974. This PR fixes an error for `Style/RedundantCurrentDirectoryInPath` when using string interpolation in `require_relative`.
rubocop · Jun 24, 2023 · 8d2c6ae · 8d2c6ae
1 parent 5a38fe3
commit 8d2c6ae
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/changelog/fix_an_error_for_style_redundant_current_directory_in_path.md b/changelog/fix_an_error_for_style_redundant_current_directory_in_path.md
@@ -0,0 +1 @@
+* [#11974](https://github.com/rubocop/rubocop/issues/11974): Fix an error for `Style/RedundantCurrentDirectoryInPath` when using string interpolation in `require_relative`. ([@koic][])
diff --git a/lib/rubocop/cop/style/redundant_current_directory_in_path.rb b/lib/rubocop/cop/style/redundant_current_directory_in_path.rb
@@ -22,7 +22,7 @@ class RedundantCurrentDirectoryInPath < Base
 
         def on_send(node)
           return unless node.method?(:require_relative)
-          return unless node.first_argument.str_content.start_with?(CURRENT_DIRECTORY_PATH)
+          return unless node.first_argument.str_content&.start_with?(CURRENT_DIRECTORY_PATH)
           return unless (index = node.first_argument.source.index(CURRENT_DIRECTORY_PATH))
 
           begin_pos = node.first_argument.source_range.begin.begin_pos + index

diff --git a/spec/rubocop/cop/style/redundant_current_directory_in_path_spec.rb b/spec/rubocop/cop/style/redundant_current_directory_in_path_spec.rb
@@ -12,6 +12,17 @@
     RUBY
   end
 
+  it "registers an offense when using a current directory path with string interpolation in `require_relative '...'`" do
+    expect_offense(<<~'RUBY')
+      require_relative './path/#{to}/feature'
+                        ^^ Remove the redundant current directory path.
+    RUBY
+
+    expect_correction(<<~'RUBY')
+      require_relative 'path/#{to}/feature'
+    RUBY
+  end
+
   it 'registers an offense when using a current directory path in `require_relative %q(...)`' do
     expect_offense(<<~RUBY)
       require_relative %q(./path/to/feature)
@@ -35,6 +46,12 @@
     RUBY
   end
 
+  it 'does not register an offense when not using a current directory path with string interpolation in `require_relative`' do
+    expect_no_offenses(<<~'RUBY')
+      require_relative "path/#{to}/feature"
+    RUBY
+  end
+
   it 'does not register an offense when not using a current directory path in not `require_relative`' do
     expect_no_offenses(<<~RUBY)
       do_something './path/to/feature'