Merge pull request #12038 from knu/output_restarting_message_to_stderr

Output the "server restarting" message to stderr
rubocop · Jul 9, 2023 · a573855 · a573855
2 parents 97af128 + 34faa8c
commit a573855
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/changelog/fix_output_the_server_restarting_message_to_stderr.md b/changelog/fix_output_the_server_restarting_message_to_stderr.md
@@ -0,0 +1 @@
+* [#12038](https://github.com/rubocop/rubocop/pull/12038): Output the "server restarting" message to stderr. ([@knu][])
diff --git a/lib/rubocop/server/client_command/exec.rb b/lib/rubocop/server/client_command/exec.rb
@@ -32,7 +32,7 @@ def run
 
         def ensure_server!
           if incompatible_version?
-            puts 'RuboCop version incompatibility found, RuboCop server restarting...'
+            warn 'RuboCop version incompatibility found, RuboCop server restarting...'
             ClientCommand::Stop.new.run
           elsif check_running_server
             return

diff --git a/spec/rubocop/server/rubocop_server_spec.rb b/spec/rubocop/server/rubocop_server_spec.rb
@@ -37,7 +37,8 @@
         RuboCop::Server::Cache.write_version_file('0.99.9')
 
         expect(`ruby -I . "#{rubocop}" --server-status`).to match(/RuboCop server .* is running/)
-        expect(`ruby -I . "#{rubocop}" #{options}`).to start_with(
+        _stdout, stderr, _status = Open3.capture3("ruby -I . \"#{rubocop}\" #{options}")
+        expect(stderr).to start_with(
           'RuboCop version incompatibility found, RuboCop server restarting...'
         )
       end