Don't mutate arguments.

Too lazy to factorize this pattern
rubocop · Aug 5, 2020 · bf47e35 · bf47e35
1 parent bcfff57
commit bf47e35
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb b/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb
@@ -37,7 +37,7 @@ def on_send(node)
           # ...then each key/value pair is treated as a method 'argument'
           # when determining where line breaks should appear.
           if (last_arg = args.last)
-            args = args.concat(args.pop.children) if last_arg.hash_type? && !last_arg.braces?
+            args = args[0...-1] + last_arg.children if last_arg.hash_type? && !last_arg.braces?
           end
 
           check_line_breaks(node, args)

diff --git a/lib/rubocop/cop/mixin/check_line_breakable.rb b/lib/rubocop/cop/mixin/check_line_breakable.rb
@@ -171,7 +171,7 @@ def process_args(args)
         # ...then each key/value pair is treated as a method 'argument'
         # when determining where line breaks should appear.
         if (last_arg = args.last)
-          args = args.concat(args.pop.children) if last_arg.hash_type? && !last_arg.braces?
+          args = args[0...-1] + last_arg.children if last_arg.hash_type? && !last_arg.braces?
         end
         args
       end