Merge pull request #8315 from eugeneius/percent_literal_delimiters_scrub

Handle invalid characters in Style/PercentLiteralDelimiters
rubocop · Jul 13, 2020 · c7b494b · c7b494b
2 parents 0a62a31 + 528bf00
commit c7b494b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -21,6 +21,7 @@
 * [#8282](https://github.com/rubocop-hq/rubocop/issues/8282): Fix `Style/IfUnlessModifier` bad precedence detection. ([@tejasbubane][])
 * [#8289](https://github.com/rubocop-hq/rubocop/issues/8289): Fix `Style/AccessorGrouping` to not register offense for accessor with comment. ([@tejasbubane][])
 * [#8310](https://github.com/rubocop-hq/rubocop/pull/8310): Handle major version requirements in `Gemspec/RequiredRubyVersion`. ([@eugeneius][])
+* [#8315](https://github.com/rubocop-hq/rubocop/pull/8315): Fix crash for `Style/PercentLiteralDelimiters` when the source contains invalid characters. ([@eugeneius][])
 
 ### Changes
 

diff --git a/lib/rubocop/cop/style/percent_literal_delimiters.rb b/lib/rubocop/cop/style/percent_literal_delimiters.rb
@@ -102,7 +102,7 @@ def contains_delimiter?(node, delimiters)
           delimiters_regexp = Regexp.union(delimiters)
           node
             .children.map { |n| string_source(n) }.compact
-            .any? { |s| delimiters_regexp.match?(s) }
+            .any? { |s| delimiters_regexp.match?(s.scrub) }
         end
 
         def string_source(node)

diff --git a/spec/rubocop/cop/style/percent_literal_delimiters_spec.rb b/spec/rubocop/cop/style/percent_literal_delimiters_spec.rb
@@ -58,6 +58,10 @@
         ^^^^^^^^^^^^^^^ `%`-literals should be delimited by `[` and `]`.
       RUBY
     end
+
+    it 'does not crash when the source contains invalid characters' do
+      expect { inspect_source('%{\x80}') }.not_to raise_error
+    end
   end
 
   context '`%q` string' do