Skip to content

Commit

Permalink
Use sh instead of system cmd, exception: true in *.rake
Browse files Browse the repository at this point in the history
  • Loading branch information
koic committed Jun 15, 2024
1 parent 452ad28 commit d123725
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tasks/changelog.rake
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace :changelog do
ref_type = :pull if args[:id]
path = Changelog::Entry.new(type: type, ref_id: args[:id], ref_type: ref_type).write
cmd = "git add #{path}"
system cmd, exception: true
sh cmd
puts "Entry '#{path}' created and added to git index"
end
end
Expand All @@ -21,7 +21,7 @@ namespace :changelog do
Changelog.new.merge!.and_delete!
cmd = "git commit -a -m 'Update Changelog'"
puts cmd
system cmd, exception: true
sh cmd
end

desc 'Check for no pending changelog entries'
Expand Down
4 changes: 2 additions & 2 deletions tasks/prof.rake
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace :prof do

path = args.fetch(:path, '.')
cmd = "exe/rubocop --profile #{path}"
system cmd, exception: true
sh cmd
end

desc 'Run RuboCop on itself only if dump does not exist'
Expand All @@ -40,6 +40,6 @@ namespace :prof do
end
cmd = "stackprof #{dump_path} --walk --method '#{method}'"
puts cmd
system cmd, exception: true
sh cmd
end
end

0 comments on commit d123725

Please sign in to comment.