Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for !~ to Style/SelectByRegexp #11219

Closed
vlad-pisanov opened this issue Dec 1, 2022 · 0 comments · Fixed by #11221
Closed

Add support for !~ to Style/SelectByRegexp #11219

vlad-pisanov opened this issue Dec 1, 2022 · 0 comments · Fixed by #11221
Labels
enhancement

Comments

@vlad-pisanov
Copy link

Currently, Style/SelectByRegexp recognizes =~ but not !~:

list.select { |n| n =~ /good/ } # cop recommends list.grep(/good/) ✔️
list.select { |n| n !~ /bad/ }  # cop ignores 😔

Ideally, it would recommend list.grep_v(/bad/)
koic added a commit to koic/rubocop that referenced this issue Dec 1, 2022
@koic
[Fix rubocop#11219] Make Style/SelectByRegexp aware of !~ method
796bbed 
Fixes rubocop#11219.

This PR makes `Style/SelectByRegexp` aware of `!~` method.
@koic koic mentioned this issue Dec 1, 2022
Merged
8 tasks
bbatsov pushed a commit that referenced this issue Dec 2, 2022
@koic @bbatsov
[Fix #11219] Make Style/SelectByRegexp aware of !~ method
658d1bc 
Fixes #11219.

This PR makes `Style/SelectByRegexp` aware of `!~` method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #11219] Make Style/SelectByRegexp aware of !~ method koic/rubocop
2 participants
@koic @vlad-pisanov