Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in 1.63.4 -- "Could not locate Gemfile" #12876

Closed
asottile opened this issue Apr 30, 2024 · 2 comments · Fixed by #12901
Closed

regression in 1.63.4 -- "Could not locate Gemfile" #12876

asottile opened this issue Apr 30, 2024 · 2 comments · Fixed by #12901

Comments

@asottile
Copy link
Contributor

same as #12846 but has regressed yet again!
@asottile asottile mentioned this issue Apr 30, 2024
Closed
@Earlopain
Copy link
Contributor

I tested 1.63.2 through 1.63.5 but the only version I can reproduce this is on 1.63.1. Can you check if this is still broken on 1.63.5 for you?

I did notice that this only reproduces if the parent directory doesn't contain a Gemfile/Lockfile so it's possible there are some other preconditions I don't know about, or perhaps it's some other issue entirely. Purely from the code I would say that this exception is now always rescued.

@Earlopain
Copy link
Contributor

Nevermind that, I saw the PR you linked to here. This happens if a Gemfile is present without a lockfile.

Earlopain added a commit to Earlopain/rubocop that referenced this issue May 14, 2024
@Earlopain
[Fix rubocop#12876] Fix lockfile parsing if only the gemfile exists
63737e2
This was referenced May 14, 2024
Open
Merged
koic added a commit that referenced this issue May 15, 2024
@koic
Merge pull request #12901 from Earlopain/bundler-gemfile-error
5e25d8f 
[Fix #12876] Fix lockfile parsing if only the gemfile exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #12876] Fix lockfile parsing if only the gemfile exists Earlopain/rubocop
2 participants
@asottile @Earlopain