Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop::Config#gem_version_to_major_minor_float doesn't work for Rails 8.0 #12898

Closed
rafaelfranca opened this issue May 13, 2024 · 0 comments
Closed

Comments

@rafaelfranca
Copy link
Contributor

See https://buildkite.com/rails/rails/builds/107101#018f72e2-502d-4242-9c8f-117e744182a3 for example.

The problem is that Rails 8.0.0.alpha is being interpreted as 8.alpha that is invalid Float. It should be interpreted as 8.0

rafaelfranca added a commit to rails/rails that referenced this issue May 13, 2024
Earlopain added a commit to Earlopain/rubocop that referenced this issue May 13, 2024
@koic koic closed this as completed in 16c8db1 May 13, 2024
koic added a commit that referenced this issue May 13, 2024
[Fix #12898] Fix parsing of `TargetRailsVersion` for prerelases
dhh pushed a commit to rails/rails that referenced this issue May 14, 2024
xjunior pushed a commit to xjunior/rails that referenced this issue Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant